Skip to content

Fix gamepiece early ejection direction [SYNTH-78]#1353

Draft
RoushilS wants to merge 3 commits into
devfrom
roushils/78/early-ejection-fix
Draft

Fix gamepiece early ejection direction [SYNTH-78]#1353
RoushilS wants to merge 3 commits into
devfrom
roushils/78/early-ejection-fix

Conversation

@RoushilS

Copy link
Copy Markdown
Contributor

Task

SYNTH-78

Symptom

If you eject a gamepiece when while it is still being intaken and hasn't reached it's final desired position, it does not shoot in the direct direction.

Solution

Set the eject vector to the final desired eject vector rather than the gamepiece's immediate one.

Verification

To Verify: First, spawn a robot in a field, and configure ejector and intake (make sure to make intake animation take 2 seconds for ease of use). Then intake and immediately eject.

  • Game piece shoots in the right direction when being ejected right after intaking.

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@RoushilS RoushilS requested review from a team as code owners June 26, 2026 00:15

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think nothing should happen. In a game, if your ejector is running while you are intaking, then the gamepiece can't even be ejected because of physics.
So if your assembly is currently intaking, then just don't eject until it is done intaking

@RoushilS

Copy link
Copy Markdown
Contributor Author

oh is that what the ticket meant? @PepperLola

@PepperLola

Copy link
Copy Markdown
Member

oh is that what the ticket meant? @PepperLola

You've implemented what I initially meant but I actually prefer Dhruv's suggestion as well since that makes more sense in a match

@RoushilS RoushilS self-assigned this Jul 1, 2026
@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator

@RoushilS is this ready for review?

@RoushilS

RoushilS commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

No, sorry I took a break from this project and have been working on other things as I kept running into bugs when trying to stop/cancel eject behavior after adding the check. I will come back to it soon. The version that simply has the object drop, and the one that has it launch both work.

@AlexD717 AlexD717 marked this pull request as draft July 9, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants