Fix gamepiece early ejection direction [SYNTH-78]#1353
Conversation
Dhruv-0-Arora
left a comment
There was a problem hiding this comment.
I personally think nothing should happen. In a game, if your ejector is running while you are intaking, then the gamepiece can't even be ejected because of physics.
So if your assembly is currently intaking, then just don't eject until it is done intaking
|
oh is that what the ticket meant? @PepperLola |
You've implemented what I initially meant but I actually prefer Dhruv's suggestion as well since that makes more sense in a match |
|
@RoushilS is this ready for review? |
|
No, sorry I took a break from this project and have been working on other things as I kept running into bugs when trying to stop/cancel eject behavior after adding the check. I will come back to it soon. The version that simply has the object drop, and the one that has it launch both work. |
Task
SYNTH-78
Symptom
If you eject a gamepiece when while it is still being intaken and hasn't reached it's final desired position, it does not shoot in the direct direction.
Solution
Set the eject vector to the final desired eject vector rather than the gamepiece's immediate one.
Verification
To Verify: First, spawn a robot in a field, and configure ejector and intake (make sure to make intake animation take 2 seconds for ease of use). Then intake and immediately eject.
Before merging, ensure the following criteria are met: