ci: update pull request actions for node 24#4773
Open
agentHits wants to merge 2 commits into
Open
Conversation
Что: - Обновлены actions checkout, setup-node и pnpm/action-setup в Pull Request workflow до v5. Зачем: - Убрать Node.js 20 deprecation annotations из pr-check jobs и использовать actions с Node.js 24 runtime. Риски: - Не выявлены; изменение ограничено версиями GitHub Actions без изменения команд workflow. Проверки: - Команды и результаты: gh api action.yml для actions/checkout@v5, actions/setup-node@v5 и pnpm/action-setup@v5 подтвердил runs.using node24; git diff --check прошел; ruby YAML parse .github/workflows/pull-request.yml вернул yaml ok; go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/pull-request.yml прошел без diagnostics; независимый Agent Flow reviewer вернул pass. - Ограничения: Локальные build/test/typecheck не запускались, потому что изменение касается только GitHub Actions workflow versions. What: - Updated checkout, setup-node, and pnpm/action-setup actions in the Pull Request workflow to v5. Why: - Remove Node.js 20 deprecation annotations from pr-check jobs and use actions with the Node.js 24 runtime. Risks: - None identified; the change is limited to GitHub Actions versions without changing workflow commands. Checks: - Commands and results: gh api action.yml for actions/checkout@v5, actions/setup-node@v5, and pnpm/action-setup@v5 confirmed runs.using node24; git diff --check passed; ruby YAML parse .github/workflows/pull-request.yml returned yaml ok; go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/pull-request.yml passed with no diagnostics; independent Agent Flow reviewer returned pass. - Limitations: Local build/test/typecheck were not run because the change only touches GitHub Actions workflow versions.
dosubot
Bot
added
the
size:XS
Что: - Обновлены actions/checkout и pinned autofix-ci/action в format workflow до Node.js 24-compatible версий. Зачем: - Убрать оставшуюся Node.js 20 deprecation annotation из autofix.ci после исправления pr-check workflow. Риски: - Не выявлены; изменение ограничено версиями GitHub Actions без изменения formatter-команды. Проверки: - Команды и результаты: gh api action.yml для autofix-ci/action@v1.3.4 подтвердил runs.using node24; git ls-remote подтвердил SHA c5b2d67aa2274e7b5a18224e8171550871fc7e4a для tag v1.3.4; git diff --check прошел; ruby YAML parse для pull-request.yml и format.yml вернул yaml ok; go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/pull-request.yml .github/workflows/format.yml прошел без diagnostics; независимый Agent Flow reviewer подтвердил корректность полного local diff и отметил, что fix нужно опубликовать. - Ограничения: Локальные build/test/typecheck не запускались, потому что изменение касается только GitHub Actions workflow versions. What: - Updated actions/checkout and the pinned autofix-ci/action in the format workflow to Node.js 24-compatible versions. Why: - Remove the remaining Node.js 20 deprecation annotation from autofix.ci after fixing the pr-check workflow. Risks: - None identified; the change is limited to GitHub Actions versions without changing the formatter command. Checks: - Commands and results: gh api action.yml for autofix-ci/action@v1.3.4 confirmed runs.using node24; git ls-remote confirmed SHA c5b2d67aa2274e7b5a18224e8171550871fc7e4a for tag v1.3.4; git diff --check passed; ruby YAML parse for pull-request.yml and format.yml returned yaml ok; go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/pull-request.yml .github/workflows/format.yml passed with no diagnostics; independent Agent Flow reviewer confirmed the full local diff is correct and noted that the fix needed to be published. - Limitations: Local build/test/typecheck were not run because the change only touches GitHub Actions workflow versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR updates the Pull Request workflow actions used by the pr-check jobs to Node.js 24-compatible major versions. It removes Node.js 20 deprecation annotations without changing the workflow commands, matrix, Node version, or pnpm cache behavior.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Local verification:
actions/checkout@v5,actions/setup-node@v5, andpnpm/action-setup@v5declareruns.using: node24.git diff --check.github/workflows/pull-request.ymlgo run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/pull-request.ymlIssues related (if applicable)
N/A
Screenshots (if applicable)
N/A