add support for node_readiness_config addon to google_container_cluster

[ajaysundark]

Add support for node-readiness-controller GKE cluster addon.

Tested:

ajaysundar@ajaysundar-cloudtop:~/workspace/magicmodules/magic-modules$ gcloud container clusters describe tf-test-nrc-rng2v7qlyz --location=us-central1-a | grep -A10 -B10 addonsConfig
addonsConfig:
  dnsCacheConfig:
    enabled: true
  gcePersistentDiskCsiDriverConfig:
    enabled: true
  kubernetesDashboard:
    disabled: true
  networkPolicyConfig:
    disabled: true
  nodeReadinessConfig:
    enabled: true

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `addons_config.node_readiness_config` field to `google_container_cluster` resource

[ajaysundark]

cc @VeraQin @zicongmei

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7062f17:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	5 files changed, 123 insertions(+)
google-beta provider	View Diff	5 files changed, 123 insertions(+)
terraform-google-conversion	View Diff	4 files changed, 41 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [addons_config.node_readiness_config.enabled]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
318	299	14	5

Affected Service Packages

• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccContainerCluster_agentSandbox
• TestAccContainerCluster_regionalWithNodePool
• TestAccContainerCluster_withNodeReadinessConfig
• TestAccContainerCluster_withSlurmOperatorConfig
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_agentSandbox
✅ Log	✅	TestAccContainerCluster_withNodeReadinessConfig
✅ Log	✅	TestAccContainerCluster_withSlurmOperatorConfig
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ajaysundark, @BBBmau VCR tests complete for 7062f17!

[ajaysundark]

Missing doc report

Fixed

TestAccContainerNodePool_withHostMaintenancePolicy

flaky, failed due to GCE_STOCKOUT-

"operationType": "CREATE_CLUSTER",
 "status": "DONE",
 "statusMessage": "Google Compute Engine: Not all instances running in IGM after 35m4.585757454s. Expected 1, running 0, transitioning 1. Current errors: [GCE_STOCKOUT]: Instance 'gke-tf-test-cluster-8ama-default-pool-412facbd-k0w6' creation failed: The zone 'projects/ci-test-project-188019/zones/us-central1-a' does not have enough resources available to fulfill the request.  '(resource type:compute)'.",
 "selfLink": "https://container.googleapis.com/v1beta1/projects/1067888929963/zones/us-central1-a/operations/operation-1784063565607-90e04e95-695b-4eb3-a16b-01e51fbd7912"

TestAccContainerCluster_regionalWithNodePool

likely a flake as well, as it is a completely unrelated field: ignore_node_count_changes to this change.

    resource_container_cluster_test.go:1989: Step 1/2 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # google_container_cluster.regional will be updated in-place
          ~ resource "google_container_cluster" "regional" {
                id                                       = "projects/ci-test-project-188019/locations/us-central1/clusters/tf-test-cluster-regional-0l8wrgokor"
                name                                     = "tf-test-cluster-regional-0l8wrgokor"
                # (39 unchanged attributes hidden)
        
              ~ node_pool {
                  ~ ignore_node_count_changes   = false -> true
                    name                        = "tf-test-cluster-nodepool-dyo7693jag"
                    # (8 unchanged attributes hidden)
        
                    # (4 unchanged blocks hidden)
                }
        
                # (29 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccContainerCluster_regionalWithNodePool (812.72s)
FAIL

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 549e804:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	5 files changed, 128 insertions(+)
google-beta provider	View Diff	5 files changed, 128 insertions(+)
terraform-google-conversion	View Diff	4 files changed, 41 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
318	302	14	2

Affected Service Packages

• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccContainerCluster_regionalWithNodePool
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ajaysundark, @BBBmau VCR tests complete for 549e804!

[BBBmau]

The two failures can be ignored since when i checked the nightly-tests they appear to be failing for quite a while

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5cea53f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	5 files changed, 128 insertions(+)
google-beta provider	View Diff	5 files changed, 128 insertions(+)
terraform-google-conversion	View Diff	4 files changed, 41 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
318	302	14	2

Affected Service Packages

• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccContainerCluster_regionalWithNodePool
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

[modular-magician]

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ajaysundark, @BBBmau VCR tests complete for 5cea53f!