Skip to content

Remove httpheaders.port field from google_cloud_run_v2_worker_pool#18290

Open
yanweiguo wants to merge 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
yanweiguo:remove_port
Open

Remove httpheaders.port field from google_cloud_run_v2_worker_pool#18290
yanweiguo wants to merge 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
yanweiguo:remove_port

Conversation

@yanweiguo

Copy link
Copy Markdown
Member

Summary

  • Remove the deprecated http_get.http_headers.port field from the Cloud Run v2 Worker Pool resource definition.
  • Mark http_get.http_headers.name field required
  • Update the 8.0.0 upgrade guide to document the removal for google_cloud_run_v2_worker_pool.
cloudrunv2: removed `http_get.http_headers.port` field from container startup probe and liveness probe in `google_cloud_run_v2_worker_pool` resource
cloudrunv2: marked `http_get.http_headers.name` field of container startup probe and liveness probe in `google_cloud_run_v2_worker_pool` resource as required

@github-actions
github-actions Bot requested a review from BBBmau July 14, 2026 21:48
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit eeab7b3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 13 insertions(+), 88 deletions(-)
google-beta provider View Diff 4 files changed, 13 insertions(+), 88 deletions(-)
terraform-google-conversion View Diff 1 file changed, 22 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field template.containers.liveness_probe.http_get.http_headers.name changed from optional to required on google_cloud_run_v2_worker_pool - reference
  • Field template.containers.liveness_probe.http_get.http_headers.port within resource google_cloud_run_v2_worker_pool was either removed or renamed - reference
  • Field template.containers.startup_probe.http_get.http_headers.name changed from optional to required on google_cloud_run_v2_worker_pool - reference
  • Field template.containers.startup_probe.http_get.http_headers.port within resource google_cloud_run_v2_worker_pool was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
90 81 9 0
Affected Service Packages
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@yanweiguo, @qwerjkl112, @BBBmau VCR tests complete for eeab7b3!

@github-actions

Copy link
Copy Markdown

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants