Fix dataFreshness default value (b/460810505)#18292
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d3efc5a: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @yair-harel VCR tests complete for d3efc5a! |
BBBmau
left a comment
There was a problem hiding this comment.
can you provide more information regarding the validation error? from a quick review it seems that the default value for data_freshness should be zero
Data freshness: The time difference between when data is written to the source and when Datastream reads the event from the source. It is calculated as the time elapsed between the source timestamp and the read timestamp for the oldest event being processed. If there are no new events to read from the source, the freshness is set to 0.
Seems like the 900s value was obtained based off of examples but doesn't quite support the idea that the default value should be 900s
Fixes b/460810505
This PR adds a default value of
900sto thedata_freshnessfield ongoogle_datastream_streamto prevent validation errors during stream creation when the field is omitted.Self-Review Checklist
Based on Magic Modules PR Review Guidelines
data_freshnessaligns with the Datastream API structure and expectations.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.