Skip to content

Support Attached Disk config in dataproc#18295

Open
sravani-bobbala wants to merge 10 commits into
GoogleCloudPlatform:mainfrom
sravani-bobbala:disk_config
Open

Support Attached Disk config in dataproc#18295
sravani-bobbala wants to merge 10 commits into
GoogleCloudPlatform:mainfrom
sravani-bobbala:disk_config

Conversation

@sravani-bobbala

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dataproc: added `attached_disk_config` to `disk_config` to support attached disks.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 15, 2026
@sravani-bobbala sravani-bobbala changed the title Disk config Support Attached Disk config in dataproc Jul 15, 2026
@sravani-bobbala
sravani-bobbala marked this pull request as ready for review July 16, 2026 16:44
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from shuyama1 July 16, 2026 16:45
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@shuyama1

Copy link
Copy Markdown
Member

Hey @sravani-bobbala, please follow go/terraform-auto-test-runs to get tests automatically triggered for your changes. Thank you!

@modular-magician modular-magician added service/dataproc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 16, 2026
@modular-magician

modular-magician commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6afe98f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 363 insertions(+), 5 deletions(-)
google-beta provider View Diff 4 files changed, 363 insertions(+), 5 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_cluster (83 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_cluster" "primary" {
  cluster_config {
    master_config {
      disk_config {
        attached_disk_config {
          disk_size_gb           = # value needed
          disk_type              = # value needed
          provisioned_iops       = # value needed
          provisioned_throughput = # value needed
        }
        num_local_ssds = # value needed
      }
      instance_flexibility_policy {
        instance_selection_list {
          disk_config {
            attached_disk_config {
              disk_size_gb           = # value needed
              disk_type              = # value needed
              provisioned_iops       = # value needed
              provisioned_throughput = # value needed
            }
          }
        }
      }
    }
    preemptible_worker_config {
      disk_config {
        attached_disk_config {
          disk_size_gb           = # value needed
          disk_type              = # value needed
          provisioned_iops       = # value needed
          provisioned_throughput = # value needed
        }
        boot_disk_provisioned_iops       = # value needed
        boot_disk_provisioned_throughput = # value needed
      }
      instance_flexibility_policy {
        instance_selection_list {
          disk_config {
            attached_disk_config {
              disk_size_gb           = # value needed
              disk_type              = # value needed
              provisioned_iops       = # value needed
              provisioned_throughput = # value needed
            }
          }
        }
      }
    }
    worker_config {
      disk_config {
        attached_disk_config {
          disk_size_gb           = # value needed
          disk_type              = # value needed
          provisioned_iops       = # value needed
          provisioned_throughput = # value needed
        }
      }
      instance_flexibility_policy {
        instance_selection_list {
          disk_config {
            attached_disk_config {
              provisioned_iops       = # value needed
              provisioned_throughput = # value needed
            }
          }
        }
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataproc_cluster
    • Expected Document Path: /website/docs/r/dataproc_cluster.html.markdown
    • Fields: [cluster_config.master_config.disk_config.attached_disk_config cluster_config.master_config.disk_config.attached_disk_config.disk_size_gb cluster_config.master_config.disk_config.attached_disk_config.disk_type cluster_config.master_config.disk_config.attached_disk_config.provisioned_iops cluster_config.master_config.disk_config.attached_disk_config.provisioned_throughput cluster_config.master_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config cluster_config.master_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.disk_size_gb cluster_config.master_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.disk_type cluster_config.master_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.provisioned_iops cluster_config.master_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.provisioned_throughput cluster_config.preemptible_worker_config.disk_config.attached_disk_config cluster_config.preemptible_worker_config.disk_config.attached_disk_config.disk_size_gb cluster_config.preemptible_worker_config.disk_config.attached_disk_config.disk_type cluster_config.preemptible_worker_config.disk_config.attached_disk_config.provisioned_iops cluster_config.preemptible_worker_config.disk_config.attached_disk_config.provisioned_throughput cluster_config.preemptible_worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config cluster_config.preemptible_worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.disk_size_gb cluster_config.preemptible_worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.disk_type cluster_config.preemptible_worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.provisioned_iops cluster_config.preemptible_worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.provisioned_throughput cluster_config.worker_config.disk_config.attached_disk_config cluster_config.worker_config.disk_config.attached_disk_config.disk_size_gb cluster_config.worker_config.disk_config.attached_disk_config.disk_type cluster_config.worker_config.disk_config.attached_disk_config.provisioned_iops cluster_config.worker_config.disk_config.attached_disk_config.provisioned_throughput cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.disk_size_gb cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.disk_type cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.provisioned_iops cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.disk_config.attached_disk_config.provisioned_throughput]

Test report

Analytics

Total Tests Passed Skipped Affected
87 79 6 2
Affected Service Packages
  • dataproc

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataprocCluster_instanceFlexibilityDiskConfig
  • TestAccDataprocCluster_workerInstanceFlexibilityPolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataprocCluster_instanceFlexibilityDiskConfig
✅ Log TestAccDataprocCluster_workerInstanceFlexibilityPolicy

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@sravani-bobbala, @shuyama1 VCR tests complete for 6afe98f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants