Skip to content

GCI: Onboard MoGCI RegionalMulticast* resources to google-nightly#18302

Open
josuesolano-google wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
josuesolano-google:feature/mogci-regional-multicast-onboarding
Open

GCI: Onboard MoGCI RegionalMulticast* resources to google-nightly#18302
josuesolano-google wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
josuesolano-google:feature/mogci-regional-multicast-onboarding

Conversation

@josuesolano-google

@josuesolano-google josuesolano-google commented Jul 15, 2026

Copy link
Copy Markdown

Tracking Bug: b/532221299
CCFE Autogen Source: //google/cloud/networkservices:v1alpha1_yaml (go/terraform-autogen)

Scope
Onboards 6 regional MoGCI (v1alpha1) resources exclusively to google-nightly (min_version: nightly):

google_network_services_regional_multicast_domain_activation
google_network_services_regional_multicast_group_range_activation
google_network_services_regional_multicast_producer_association
google_network_services_regional_multicast_consumer_association
google_network_services_regional_multicast_group_producer_activation
google_network_services_regional_multicast_group_consumer_activation

release-note:none

@github-actions
github-actions Bot requested a review from SirGitsalot July 15, 2026 22:47
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@josuesolano-google

Copy link
Copy Markdown
Author

/reset

@modular-magician

modular-magician commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6e826de:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 1523 insertions(+)
google-beta provider View Diff 30 files changed, 9548 insertions(+)
terraform-google-conversion View Diff 6 files changed, 1154 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_regional_multicast_consumer_association (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_regional_multicast_consumer_association" "primary" {
  description = # value needed
  labels      = # value needed
}

Resource: google_network_services_regional_multicast_domain_activation (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_regional_multicast_domain_activation" "primary" {
  description = # value needed
  labels      = # value needed
  pim_spec {
    rp_ip_address = # value needed
  }
}

Resource: google_network_services_regional_multicast_group_consumer_activation (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_regional_multicast_group_consumer_activation" "primary" {
  description = # value needed
  labels      = # value needed
  log_config {
    enabled = # value needed
  }
}

Resource: google_network_services_regional_multicast_group_producer_activation (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_regional_multicast_group_producer_activation" "primary" {
  description = # value needed
  labels      = # value needed
}

Resource: google_network_services_regional_multicast_group_range_activation (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_regional_multicast_group_range_activation" "primary" {
  description = # value needed
  labels      = # value needed
  log_config {
    enabled = # value needed
  }
  pim_spec {
    rp_ip_address = # value needed
  }
}

Resource: google_network_services_regional_multicast_producer_association (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_regional_multicast_producer_association" "primary" {
  description = # value needed
  labels      = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_services_regional_multicast_consumer_association
  • google_network_services_regional_multicast_domain_activation
  • google_network_services_regional_multicast_group_consumer_activation
  • google_network_services_regional_multicast_group_producer_activation
  • google_network_services_regional_multicast_group_range_activation
  • google_network_services_regional_multicast_producer_association

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_network_services_regional_multicast_consumer_association, google_network_services_regional_multicast_domain_activation, google_network_services_regional_multicast_group_consumer_activation, google_network_services_regional_multicast_group_producer_activation, google_network_services_regional_multicast_group_range_activation, google_network_services_regional_multicast_producer_association. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
107 99 2 6
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesRegionalMulticastConsumerAssociation_networkServicesRegionalMulticastConsumerAssociationBasicExample
  • TestAccNetworkServicesRegionalMulticastDomainActivation_networkServicesRegionalMulticastDomainActivationBasicExample
  • TestAccNetworkServicesRegionalMulticastGroupConsumerActivation_networkServicesRegionalMulticastGroupConsumerActivationBasicExample
  • TestAccNetworkServicesRegionalMulticastGroupProducerActivation_networkServicesRegionalMulticastGroupProducerActivationBasicExample
  • TestAccNetworkServicesRegionalMulticastGroupRangeActivation_networkServicesRegionalMulticastGroupRangeActivationBasicExample
  • TestAccNetworkServicesRegionalMulticastProducerAssociation_networkServicesRegionalMulticastProducerAssociationBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccNetworkServicesRegionalMulticastConsumerAssociation_networkServicesRegionalMulticastConsumerAssociationBasicExample
❌ Error · Log - TestAccNetworkServicesRegionalMulticastDomainActivation_networkServicesRegionalMulticastDomainActivationBasicExample
❌ Error · Log - TestAccNetworkServicesRegionalMulticastGroupConsumerActivation_networkServicesRegionalMulticastGroupConsumerActivationBasicExample
❌ Error · Log - TestAccNetworkServicesRegionalMulticastGroupProducerActivation_networkServicesRegionalMulticastGroupProducerActivationBasicExample
❌ Error · Log - TestAccNetworkServicesRegionalMulticastGroupRangeActivation_networkServicesRegionalMulticastGroupRangeActivationBasicExample
❌ Error · Log - TestAccNetworkServicesRegionalMulticastProducerAssociation_networkServicesRegionalMulticastProducerAssociationBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@josuesolano-google, @SirGitsalot VCR tests complete for 6e826de!

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8a7be75:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d1220c5:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 77e4dab:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@josuesolano-google

Copy link
Copy Markdown
Author

@jgforsberg Could you please take a look at this PR onboarding 6 Regional MoGCI resources to google-nightly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants