GCI: Onboard MoGCI RegionalMulticast* resources to google-nightly#18302
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
/reset |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6e826de: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_regional_multicast_consumer_association" "primary" {
description = # value needed
labels = # value needed
}
Resource: resource "google_network_services_regional_multicast_domain_activation" "primary" {
description = # value needed
labels = # value needed
pim_spec {
rp_ip_address = # value needed
}
}
Resource: resource "google_network_services_regional_multicast_group_consumer_activation" "primary" {
description = # value needed
labels = # value needed
log_config {
enabled = # value needed
}
}
Resource: resource "google_network_services_regional_multicast_group_producer_activation" "primary" {
description = # value needed
labels = # value needed
}
Resource: resource "google_network_services_regional_multicast_group_range_activation" "primary" {
description = # value needed
labels = # value needed
log_config {
enabled = # value needed
}
pim_spec {
rp_ip_address = # value needed
}
}
Resource: resource "google_network_services_regional_multicast_producer_association" "primary" {
description = # value needed
labels = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @josuesolano-google, @SirGitsalot VCR tests complete for 6e826de! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8a7be75: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d1220c5: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 77e4dab: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
@jgforsberg Could you please take a look at this PR onboarding 6 Regional MoGCI resources to google-nightly? |
Tracking Bug: b/532221299
CCFE Autogen Source: //google/cloud/networkservices:v1alpha1_yaml (go/terraform-autogen)
Scope
Onboards 6 regional MoGCI (v1alpha1) resources exclusively to google-nightly (min_version: nightly):
google_network_services_regional_multicast_domain_activation
google_network_services_regional_multicast_group_range_activation
google_network_services_regional_multicast_producer_association
google_network_services_regional_multicast_consumer_association
google_network_services_regional_multicast_group_producer_activation
google_network_services_regional_multicast_group_consumer_activation
release-note:none