feat(tui): navigate panels via Up/Down arrow overflow at list boundaries

[varshaprasad96]

Summary

When the cursor reaches the boundary of a TUI dashboard panel list, Up/Down arrow keys now overflow into the adjacent panel instead of clamping silently. Down at the bottom of a panel moves focus to the next panel (cursor at first item); Up at the top moves to the previous panel (cursor at last item). Empty panels are skipped. The ring wraps: Gateways → Providers/GlobalSettings → Sandboxes → Gateways.

Related Issue

Closes #2273

Changes

• Added DASHBOARD_PANELS const array defining the panel ring order
• Added panel_item_count() helper that returns item count for any panel, respecting the active middle-pane tab (Providers vs GlobalSettings)
• Added set_panel_cursor() helper to set the selected index for any panel
• Added overflow_focus_down() and overflow_focus_up() methods that walk the panel ring to find the next/previous non-empty panel
• Modified all four dashboard key handlers (handle_gateways_key, handle_providers_key, handle_global_settings_key, handle_sandboxes_key) to call overflow helpers at list boundaries instead of clamping

Testing

• rustfmt --edition 2024 --check passes
• cargo check -p openshell-tui compiles cleanly
• Unit tests added/updated — App::new requires a gRPC client, making isolated unit tests impractical without test infrastructure changes
• E2E tests added/updated (if applicable)
• Manually tested with a live gateway and sandbox:
  • Down at bottom of each panel → moves to next panel (cursor at first item)
  • Up at top of each panel → moves to previous panel (cursor at last item)
  • Wrap-around works in both directions
  • Empty panels are skipped
  • Mid-list Up/Down scrolls normally within a panel
  • TAB navigation unaffected
  • Middle pane tab switching (h/l) unaffected
  • GlobalSettings tab respects overflow correctly

Checklist

• Follows Conventional Commits
• Commits are signed off (DCO)

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

All contributors have signed the DCO ✍️ ✅
_{Posted by the DCO Assistant Lite bot.}

[varshaprasad96]

I have read the DCO document and I hereby sign the DCO.

[johntmyers]

recheck

[johntmyers]

gator-agent

PR Review Status

Validation: This is a small, concentrated TUI enhancement implementing the clear user path in #2273. The change stays within the dashboard navigation subsystem and covers the Providers/Global Settings middle-pane variant.

Head SHA: b3251b8bbefc65b99fd8cef1f7f8c1ba63c9498b

Thanks @johntmyers — I checked the current head after your recheck comment, including the full diff, surrounding list-refresh behavior, linked issue requirements, docs impact, and existing checks.

Review findings:

• Author action required: The four Up handlers check only whether the selected cursor is greater than zero. When a previously populated gateways, providers, global-settings, or sandboxes list becomes empty, refresh logic can leave a nonzero cursor behind. Pressing Up then decrements that invisible cursor instead of immediately skipping the empty panel. Please gate each decrement on the active list still having items, as the Down handlers already do (for example, self.provider_count > 0 && self.provider_selected > 0), with equivalent guards for the other three lists.
• Automated coverage is recommended for forward/backward wraparound, consecutive empty panels, both middle-pane tabs, and a list becoming empty with a stale cursor. The ring calculation can be extracted into a pure helper without constructing a gRPC-backed App.

Docs: Missing for this direct user-facing keyboard behavior. Please add a short dashboard-navigation note to docs/sandboxes/manage-sandboxes.mdx describing Tab/Shift+Tab and Up/Down or j/k boundary overflow. No docs/index.yml change is needed because the existing page is already in navigation.

E2E: No test:* label is needed for this local TUI focus-state change.

Next state: gator:in-review

[johntmyers]

/ok to test b3251b8

[varshaprasad96]

The review comments have been addressed.

[johntmyers]

gator-agent

Re-check After Author Update

Thanks @varshaprasad96. I re-evaluated head 2d885e9cb75c240f36c66d95fa245be12908c1d3 after your July 16 comment that the review requests were addressed.

What I checked: the full current diff, the prior stale-cursor finding across all four dashboard handlers, empty-panel skipping, both middle-pane tabs, linked issue #2273, and the Fern documentation update.

Disposition: resolved. Each Up handler now verifies that its active list is non-empty before decrementing, so a stale nonzero cursor on an empty list overflows immediately. The dashboard keyboard behavior is now documented on the existing Manage Sandboxes page; no docs/index.yml change is needed.

Review findings:

• No blocking correctness, security, maintainability, or documentation findings remain.
• Automated table-driven coverage for both directions, wraparound, empty-panel skipping, stale selections, and both middle-pane tabs is still recommended but is not blocking this review.

E2E: No test:* label is needed for this local TUI focus-state change.

Next state: gator:watch-pipeline

[johntmyers]

/ok to test 2d885e9

[johntmyers]

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: Head 2d885e9cb75c240f36c66d95fa245be12908c1d3 had no remaining blocking gator findings, required status contexts were green, and maintainer approval was present before merge. The last active state was gator:approval-needed.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.