fix(driver-vm): run sandbox supervisor as guest pid 1#2299
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
PR Review StatusValidation: This is a concentrated VM-driver fix for the confirmed and linked bug in #1998, authored by a repository maintainer. Review findings:
Docs: Fern docs are not needed because this restores documented VM behavior without changing commands, configuration, or user workflow. The architecture invariant is documented in Next state: |
|
Label |
Summary
Run the VM guest bootstrap as PID 1 so it can exec
openshell-sandboxin place. This prevents/init.krunfrom appearing as an unverifiable ancestor during network policy evaluation and incorrectly denying allowed egress.Related Issue
Closes #1998
Changes
KRUN_INIT_PID1=1in the authoritative libkrun guest environment and remove caller overridesTesting
mise run pre-commitpassescargo test -p openshell-driver-vm libkrun_guest_envmise run e2e:vmOPENSHELL_E2E_VM_TEST=host_gateway_alias mise run e2e:vmChecklist