ZXHawk - Big updates#4792
Open
Asnivor wants to merge 12 commits into
Open
Conversation
…ion. Flux-format based with timing accuracy across controller and drive. Now supports IPF.
…ycle-correct. Fixed a number of TZX, CSW, WAV & PZX format parsing bugs.
…M2149. Moved to Cores\Sound.
This comment was marked as resolved.
This comment was marked as resolved.
YoshiRulz
requested changes
Jul 11, 2026
YoshiRulz
left a comment
Member
There was a problem hiding this comment.
Where to begin... clearly I haven't enabled enough Analyzer rules. Non-exhaustive list:
- braces XOR single-line
- newline before
=> - space after cast
- go easy on the hand-aligned comments (/
[ ]{2,}/ should not match your code) - doc comments are HTML-like: you don't need to fold at 80 cols, and you can use line breaks and bullet lists
- use
iswith constant RHS - coalesce subsequent checks into pattern matching
- s/
for (;;)/while (true)/ - add a
usingstatement instead of writing FQN - use existing data structures and helper methods
- use LINQ; if it's too slow, write a helper method
- use
{ReadOnly,}Span - use
u8literal instead of casting UTF-16chars - use string interpolation
- omit type when assigning field/prop with
new() - use named arguments unless types make it unambiguous
- don't merge field/local declarations
- enable NRTs in new files
- why rename the
Z80Atype and namespace? just the namespace would suffice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously, previous savestates are not compatible.
Check if completed: