Conversation
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
github-actions
Bot
added
C-client
There was a problem hiding this comment.
Pull request overview
This PR updates the protobuf/tonic code generation build scripts to avoid post-processing generated Rust code, using tonic_prost_build::Builder::extern_path instead to correctly reference shared proto packages.
Changes:
- Replaces the generated-code string-rewrite “fixup” step with
extern_path(...)mappings for containerd and google RPC proto packages. - Splits client proto generation into separate “types” and “services” compilation phases, ensuring services reference the already-generated type modules.
- Replaces the previous doc-comment rewrite workaround with
disable_comments(...)for specific problematicfiltersfield comments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/snapshots/build.rs | Uses extern_path for .containerd.types and disables a problematic doc comment, removing generated-code rewriting. |
| crates/client/build.rs | Splits type vs service proto generation and uses extern_path mappings (types/v1/transfer/google.rpc), removing generated-code rewriting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jokemanfire
reviewed
Jul 15, 2026
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
jokemanfire
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.