feat(server-utils): Port Bedrock aws-sdk extension and add integration tests#22166
Draft
andreiborza wants to merge 4 commits into
Draft
feat(server-utils): Port Bedrock aws-sdk extension and add integration tests#22166andreiborza wants to merge 4 commits into
andreiborza wants to merge 4 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
bdc838e to
9297436
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
188ac82 to
ff165d4
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
9297436 to
31816fd
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
ff165d4 to
a4dd353
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
31816fd to
0b89e37
Compare
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
a4dd353 to
968db2f
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
0b89e37 to
a3978fa
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
968db2f to
5f2a15f
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
2 times, most recently
from
809da29 to
8907ff9
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
5f2a15f to
8f3599b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
8907ff9 to
c0e10d6
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
8f3599b to
0a944ab
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
c0e10d6 to
561e41b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
0a944ab to
5506257
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
561e41b to
8ffb46b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
14699e8 to
a464258
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
2 times, most recently
from
556da6f to
9f3cab7
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
2849cfe to
8e57368
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
9f3cab7 to
ab2bf1b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
8e57368 to
a265ce7
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
2 times, most recently
from
506ad88 to
8b3b56a
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
a265ce7 to
187e0a3
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
8b3b56a to
08dc65d
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
fe87011 to
2a870f9
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
08dc65d to
9d72288
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
2a870f9 to
f5a83fc
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
9d72288 to
783f36b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
f5a83fc to
0d656fc
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
783f36b to
4a6b212
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
0d656fc to
334e8d0
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
334e8d0 to
777b8fa
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
4a6b212 to
540249c
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
777b8fa to
147d1ed
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
2 times, most recently
from
3f96053 to
c069617
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
147d1ed to
b68b1ab
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
c069617 to
96af43c
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
b68b1ab to
3a1517b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a1517b. Configure here.
…n tests Ports the BedrockRuntime gen_ai service extension from the OTel aws-sdk integration to the orchestrion channel integration: chat span name and request parameters for `Converse`/`ConverseStream`, per-model-family request body parsing for `InvokeModel`/`InvokeModelWithResponseStream` (titan, nova, claude, llama, cohere, mistral), token usage and finish reasons from responses, and deferred span end for the streaming commands (the span ends when the wrapped stream is consumed). Adds nock-mocked integration tests for the non-streaming `Converse` and `InvokeModel` commands, asserted against both the OTel and diagnostics-channel paths. The streaming commands use the AWS binary eventstream framing which nock cannot mock, so they stay untested here. This completes orchestrion parity with the OTel aws-sdk integration. Fixes #20946 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The model family is fixed for the whole stream, so resolve the recorder once and skip parsing entirely for unrecognized families; chunks are the highest frequency loop in the integration.
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
3a1517b to
e61c577
Compare
andreiborza
force-pushed
the
ab/aws-sdk-serverless
branch
from
96af43c to
4294c76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the BedrockRuntime gen_ai service extension from the OTel aws-sdk integration to the orchestrion channel integration: chat span name and request parameters for
Converse/ConverseStream, per-model-family request body parsing forInvokeModel/InvokeModelWithResponseStream(titan, nova, claude, llama, cohere, mistral), token usage and finish reasons from responses, and deferred span end for the streaming commands (the span ends when the wrapped stream is consumed).Adds nock-mocked integration tests for the non-streaming
ConverseandInvokeModelcommands, asserted against both the OTel and diagnostics-channel paths. The streaming commands use the AWS binary eventstream framing which nock cannot mock, so they stay untested here.This completes orchestrion parity with the OTel aws-sdk integration.
User-facing differences to the vendored OTel instrumentation
ConverseStreamcallers receive the original response object with itsstreamwrapped in place, instead of a new object (a channel subscriber can't replace the resolved value); relevant only to identity-sensitive codeFixes #20946