Scroll to top when navigating between recipes#91
Merged
Conversation
Tapping a recommended recipe navigates to the same /recipes/details pathname with a different ?id= query, so React Router does not reset the scroll position and the user lands mid-page. Scroll to the top whenever the recipe id changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tapping a recommended recipe at the bottom of a recipe page navigates to another recipe, but the user stays scrolled near the bottom instead of seeing the top of the new recipe.
The cause: recipe pages all share the
/recipes/detailspathname and differ only by the?id=query param, so React Router treats it as the same location and never resets the scroll position.Fix
Added a
useEffectinRecipePagekeyed onrecipeIdthat callswindow.scrollTo(0, 0)whenever the recipe changes. This covers tapping a recommended recipe as well as any other in-app navigation between recipes (e.g. from the History page).Test plan
🤖 Generated with Claude Code