Withdrawn#112
Closed
deividasma wants to merge 1 commit into
Closed
Conversation
Embed Phrase ICE (HSTG-21088) so translators can edit strings directly on the staging deployment. Since the frontend is compiled into a single binary, ICE is included at build time: make build-staging (vite build --mode staging) compiles it in, while production builds eliminate it entirely. Even on staging, ICE stays dormant until a translator opts in via ?phraseapp=enabled (week-long cookie), and QA automation sessions never activate it. Follows the hpanel/hcart/hwebsites convention: PHRASEAPP_CONFIG global, cdn.phrase.com editor script, [[__ __]] key decorators via a vue-i18n postTranslation hook. Keys are decorated only after the CDN script has initialised (markers rendered earlier never get edit bubbles), and a synthetic scroll is dispatched on DOM changes because ICE only re-scans the page on scroll.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
deividasma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.