fix: convert emoji in markdown text tokens#3037
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @Semak12345! 🚀 Here’s what will happen next:
|
📝 WalkthroughWalkthroughChangesEmoji rendering and heading slugs
Sequence Diagram(s)sequenceDiagram
participant MarkdownInput
participant MarkdownRenderer
participant emojiText
participant Sanitizer
MarkdownInput->>MarkdownRenderer: render markdown tokens
MarkdownRenderer->>emojiText: process text tokens
emojiText-->>MarkdownRenderer: return rendered emoji text
MarkdownRenderer->>Sanitizer: sanitise rendered HTML
Sanitizer-->>MarkdownRenderer: return sanitised HTML
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gameroman
left a comment
There was a problem hiding this comment.
Please use the pull request template
Closes #2822
Moves emoji conversion into the marked text renderer instead of scanning rendered HTML for code tags. Inline code, fenced code, and escaped shortcodes now bypass conversion naturally. Shortcode-based heading anchors remain unchanged.
Tested with: