gh-149162: Use _Py_LOCK_DONT_DETACH in intern_common#149164
Merged
nascheme merged 2 commits intoJul 16, 2026
Merged
Conversation
Avoids potential deadlocks with C++ static local initialization in extensions that call PyUnicode_InternFromString during one-time initialization.
colesbury
added
topic-free-threading
needs backport to 3.14
colesbury
marked this pull request as ready for review
April 29, 2026 20:12
mpage
approved these changes
Apr 30, 2026
StanFromIreland
added
the
needs backport to 3.15
Member
|
Anything need to be done yet or can this be merged? |
Contributor
Author
|
It can be merged
…On Thu, Jul 16, 2026 at 2:26 AM Neil Schemenauer ***@***.***> wrote:
*nascheme* left a comment (python/cpython#149164)
<#149164 (comment)>
Anything need to be done yet or can this be merged?
—
Reply to this email directly, view it on GitHub
<#149164?email_source=notifications&email_token=AAFAD6QQRNEITSN5UP6ELCL5FBYS7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJYHA4DMOBVHE4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4988868598>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFAD6QNC2A5S5FFEA4A2Q35FBYS7AVCNFSNUABEKJSXA33TNF2G64TZHM4DCNJZHA4TMMJ3JFZXG5LFHM2DGNJTGM4DCMZXG6QXMAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks @colesbury for the PR, and @nascheme for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @colesbury and @nascheme, I could not cleanly backport this to |
|
GH-153814 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-153815 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids potential deadlocks with C++ static local initialization in extensions that call PyUnicode_InternFromString during one-time initialization.
intern_commonshould use_Py_LOCK_DONT_DETACH#149162