Support legacy Kotlin property path rendering.#3510
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
Closes spring-projects#3503 Signed-off-by: hutiefang <hutiefang@qq.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kotlin property-path DSL moved from
org.springframework.data.mappingtoorg.springframework.data.core, but a path built with the deprecated mappingdivextensions was not recognized by the new coretoDotPath. As a result, paths such asauthor.nameandbooks.author.namewere reduced to their final segment.This change lets the core renderer recognize both legacy mapping path wrappers. It only expands the legacy non-iterable wrapper from
privatetointernal; public extension signatures remain unchanged.Tests:
./mvnw -Dtest=KPropertyPathTests test(13 tests)Core and mapping property-path suites together (25 tests)
./mvnw -DskipTests packagegit diff --checkI have read the Spring Data contribution guidelines.
I followed the existing Kotlin import and formatting style.
I added regression coverage for normal, iterable, and recursively nested legacy paths.
I added myself as an author to the Kotlin types and test class I touched.
Closes #3503