feat: add Paykit server accounts#1084
Open
ben-kaufman wants to merge 11 commits into
Open
Conversation
5 tasks
Greptile SummaryThis PR adds Paykit Server watch-only accounts. The main changes are:
Confidence Score: 5/5No additional blocking issue qualifies for this follow-up review.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/ui/screens/profile/PubkyAuthApprovalViewModel.kt | Coordinates consent, local authentication, companion delivery, remote authorization, and account activation. |
| app/src/main/java/to/bitkit/repositories/WatchOnlyAccountRepo.kt | Manages watch-only account allocation, claims, lifecycle transitions, and LDK tracking. |
| app/src/main/java/to/bitkit/services/LightningService.kt | Adds watch-only accounts to node configuration and reconciles their tracking state. |
Reviews (2): Last reviewed commit: "fix: align Paykit auth UI" | Re-trigger Greptile
601cdaa to
3e1064d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #1066 to add Paykit Server watch-only accounts:
x-bitkit-claim=watch-only-account-v1and the exact/pub/paykit/v0/bitkit/server/:rwcapability, rejecting missing, unknown, duplicate, or mismatched companion parameters.approveAuthWithCompanionClaim, failing closed if companion delivery or normal authorization fails.0.1.0-rc36, LDK Node0.7.0-rc.56, and Bitkit Core0.4.2; Bitkit Core now supplies trusted extended-public-key serialization, so BitcoinJ is no longer required.The relay claim contains only the versioned account index, address type, and serialized xpub. Local names and tracking state are not disclosed. Ordinary Pubky Auth remains unchanged.
References:
QA Notes
Manual Tests
Automated Checks
WatchOnlyAccountClaimCodecTest.ktWatchOnlyAccountStoreTest.ktWatchOnlyAccountRepoTest.ktWatchOnlyAccountLifecycleCoordinatorTest.ktWatchOnlyAccountRestoreTest.ktPubkyAuthApprovalViewModelTest.ktPubkyAuthRequestTest.ktPubkyRepoTest.ktLightningServiceTest.kt./gradlew compileDevDebugKotlin./gradlew testDevDebugUnitTest./gradlew detekt(passes with unrelated existing findings)