fix: use fast fee for hw transfer#634
Merged
Merged
Conversation
Trezor → spending funding was using the settings default fee tier (normal), which can resolve to 1 sat/vB and leave channel funding unconfirmed while savings already uses fast. Align HW funding to fast and raise the estimate-unavailable fallback from 1 to 3 sat/vB. Fixes #633 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThis PR increases the fee rate used for hardware-wallet funding. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| Bitkit/AppScene.swift | Selects the fast fee tier for hardware-wallet funding. |
| Bitkit/ViewModels/HwFundingSigner.swift | Raises the fallback fee-rate defaults from 1 to 3 sat/vB. |
| BitkitTests/HwFundingSignerTests.swift | Updates the fallback reserve-floor expectation to 3,600 sats. |
| changelog.d/next/633.fixed.md | Documents the faster hardware-wallet funding fee. |
Reviews (1): Last reviewed commit: "chore: rename changelog fragment" | Re-trigger Greptile
Collaborator
Author
|
Tested end-to-end on mainnet (Trezor → spending / Blocktank channel open).
Fix confirmed end-to-end on mainnet. |
piotr-iohk
enabled auto-merge
July 17, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #633
This PR makes Trezor → spending funding use the same fast on-chain fee rate as savings → spending, so LSP channel funding confirms more reliably.
Description
Related Android: synonymdev/bitkit-android#1088
Linked Issues/Tasks
Screenshot / Video
N/A
QA Notes
Manual Tests
regression:Savings → Transfer → Spending: still uses fast and completes as before.Automated Checks
HwFundingSignerTests.swift.xcodebuild testforHwFundingSignerTests.Made with Cursor