Remove argc <= 14 limit in signing tool#825
Open
mattia-moffa wants to merge 1 commit into
Open
Conversation
danielinux
approved these changes
Jul 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes an artificial upper bound on the number of command-line arguments accepted by the tools/keytools/sign.c signing tool, keeping only the minimum argument check required to show usage.
Changes:
- Removed the
argc > 14rejection so the signing tool can accept more than 14 arguments/options. - Kept the existing minimum-argument (
argc < 4) usage guard unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a legacy limit that's not needed anymore, since it can be overcome with valid arguments.